Add a RunOnEventLoop method to modulestest.Runtime
#3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
changed the title
RunOnEventLoop method to modulestest.RuntimeRunOnEventLoop method to modulestest.Runtime
Codecov Report
@@ Coverage Diff @@
## master #3181 +/- ##
==========================================
+ Coverage 72.78% 72.80% +0.01%
==========================================
Files 256 256
Lines 19697 19703 +6
==========================================
+ Hits 14337 14344 +7
+ Misses 4464 4463 -1
Partials 896 896
Flags with carried forward coverage won't be shown. Click here to find out more.
|
oleiade
force-pushed
the
feature/modulestest-runtime-RunOnEventLoop
branch
from
2b84825 to
4f152fd
Compare
mstoykov
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This Pull Request adds a
RunOnEventLoopmethod to themodulestest.Runtime, to facilitate testing code that should be dispatched to the event loop, such as code that returns promises.Why?
While writing tests for the #3142, I stumbled upon this code from @mstoykov, with a
TODOattached. I thought that as I was about to copy-paste that snippet anyway, I might as well do as instructed inTODOand move the code to themodulestest.Runtimeclass.The
TODOhinted at potential improvements without detailing that I'd be nonetheless happy to include if necessary 🤞🏻Checklist
make ci-like-lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)